Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable table to screen width wrapping for wide tables #1748

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

azthec
Copy link

@azthec azthec commented Oct 18, 2024

Hello, I've been trying to use this tool to query large tables, with many columns, as well as with plain text editors.

I've noticed that the Rich text library used has overflow methods for tables, however there was no way to configure the table width or disable wrapping completely, and that made tables with many columns completely unreadable.

After these changes snow sql is now usable with pagers such as less and outputting to files for these large tables.

I've not yet added tests or completed the pre-review checklist, as I would like to first know if such an option is something you're interested in adding.

I am not overly attached to the new argument names, or the way I did it, so let me know if you have any suggestions.

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

@azthec azthec requested a review from a team as a code owner October 18, 2024 18:05
@azthec azthec marked this pull request as draft October 21, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant